Re: [PATCH 14/35] media: dvb-frontends: drx39xyj: Use min macro
From: Bryan O'Donoghue
Date: Tue Apr 23 2024 - 12:40:41 EST
On 15/04/2024 20:34, Ricardo Ribalda wrote:
Simplifies the code.
Found by cocci:
drivers/media/dvb-frontends/drx39xyj/drxj.c:1447:23-24: WARNING opportunity for min()
drivers/media/dvb-frontends/drx39xyj/drxj.c:1662:21-22: WARNING opportunity for min()
drivers/media/dvb-frontends/drx39xyj/drxj.c:1685:24-25: WARNING opportunity for min()
Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
Code is fine but, I think your commit log could use some love.
"Replace ternary assignments with min() to simplify and make the code
more readable."
Not super-important.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>