Re: limits.h in tools/

From: Andy Shevchenko
Date: Tue Apr 23 2024 - 15:29:49 EST


On Tue, Apr 23, 2024 at 04:22:01PM -0300, Arnaldo Carvalho de Melo wrote:
> On Tue, Apr 23, 2024 at 09:58:07PM +0300, Andy Shevchenko wrote:
> > It seems tons of the code in tools include linux/limits.h. But I haven't found
> > where do we copy it. Any pointers?
> >
> > Based on the discussion 20220603183231.15159C385A9@xxxxxxxxxxxxxxx.
>
> ⬢[acme@toolbox perf-tools-next]$ diff -u /usr/include/linux/limits.h include/uapi/linux/limits.h
> --- /usr/include/linux/limits.h 2024-01-31 21:00:00.000000000 -0300
> +++ include/uapi/linux/limits.h 2024-02-03 16:18:02.652000641 -0300
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> -#ifndef _LINUX_LIMITS_H
> -#define _LINUX_LIMITS_H
> +#ifndef _UAPI_LINUX_LIMITS_H
> +#define _UAPI_LINUX_LIMITS_H
>
> #define NR_OPEN 1024
>
> ⬢[acme@toolbox perf-tools-next]$
>
> And in the places where I test build perf I saw no problem so far, the
> build failures below are unrelated, but still outstanding, see below.
>
> But then is for building tools/, not the kernel, right? The discussion
> you said this question was based on is about changing
> include/linux/xarray.h, a kernel file, so should really be including
> just kernel headers, files in the kernel source tree, outside tools/, I
> don't see where what tools/ uses to build is relevant here? Can you
> please elaborate?

I believe the tool in question is tools/testing/radix-tree/xarray.c.

--
With Best Regards,
Andy Shevchenko