[PATCH v1 1/1] RDMA/mana_ib: Fix compilation error

From: Andy Shevchenko
Date: Tue Apr 23 2024 - 16:43:18 EST


The compilation with CONFIG_WERROR=y is broken:

../hw/mana/device.c:88:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
if (!upper_ndev) {
^~~~~~~~~~~

Fix this by assigning the ret to -ENODEV in respective condition.

Fixes: 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
drivers/infiniband/hw/mana/device.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/mana/device.c b/drivers/infiniband/hw/mana/device.c
index fca4d0d85c64..4c45f8681e7f 100644
--- a/drivers/infiniband/hw/mana/device.c
+++ b/drivers/infiniband/hw/mana/device.c
@@ -88,6 +88,7 @@ static int mana_ib_probe(struct auxiliary_device *adev,
if (!upper_ndev) {
rcu_read_unlock();
ibdev_err(&dev->ib_dev, "Failed to get master netdev");
+ ret = -ENODEV;
goto free_ib_device;
}
ether_addr_copy(mac_addr, upper_ndev->dev_addr);
--
2.43.0.rc1.1336.g36b5255a03ac