Re: [PATCH 4/4] arm: dts: allwinner: drop underscore in node names

[Rob Herring]

On Sun, Mar 17, 2024 at 1:41 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> Underscores should not be used in node names (dtc with W=2 warns about
> them), so replace them with hyphens.  Use also generic name for pwrseq
> node, because generic naming is favored by Devicetree spec.  All the
> clocks affected by this change use clock-output-names, so resulting
> clock name should not change.  Functional impact checked with comparing
> before/after DTBs with dtx_diff and fdtdump.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

This adds warnings:

13  prcm@1f01400: 'ahb0-clk', 'apb0-clk', 'apb0-gates-clk',
'apb0-rst', 'ar100-clk', 'ir-clk' do not match any of the regexes:
'^.*_(clk|rst)$', 'pinctrl-[0-9]+'

Since we documented it with underscores, I'd say just leave these at
least until if/when we define some standard names. I'd prefer we spend
time reducing warnings from the common schema. I'm looking at
root-node.yaml. simple-bus.yaml generates a lot too.

Rob