Re: [PATCH 1/2] dt-bindings: arm: ti: Add BeagleY-AI

[Andrew Davis]

On 4/23/24 2:48 PM, Robert Nelson wrote:
> On Mon, Apr 22, 2024 at 3:57 PM Andrew Davis <afd@xxxxxx> wrote:
> > On 3/28/24 2:12 PM, Robert Nelson wrote:
> > > This board is based on ti,j722s
> > >
> > > https://beagley-ai.org/
> > > https://openbeagle.org/beagley-ai/beagley-ai
> > >
> > > Signed-off-by: Robert Nelson <robertcnelson@xxxxxxxxx>
> > > CC: Rob Herring <robh@xxxxxxxxxx>
> > > CC: Nishanth Menon <nm@xxxxxx>
> > > CC: Jared McArthur <j-mcarthur@xxxxxx>
> > > CC: Jason Kridner <jkridner@xxxxxxxxxxxxxxx>
> > > CC: Deepak Khatri <lorforlinux@xxxxxxxxxxxxxxx>
> > > ---
> > >    Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
> > >    1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > > index 52b51fd7044e..ca23b7e6a35e 100644
> > > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > > @@ -134,6 +134,7 @@ properties:
> > >          - description: K3 J722S SoC and Boards
> > >            items:
> > >              - enum:
> > > +              - beagle,j722s-beagley-ai
> >
> > Recommend "beagle,am67-beagley-ai". The "J722s" is the family
> > name, the part used on this board is the AM67. We do the same
> > for the SK boards, for example, the SK-AM69 uses the AM69
> > part from the J784s4 family, so it is called k3-am69-sk.dts
> > with compatible = "ti,am69-sk", "ti,j784s4";
> >
> > This would otherwise be the first board with a specific part
> > attached but uses the SoC family name instead of that specific
> > part name in the DT file/name. Only the EVMs should have the
> > family name since we sell versions of those with all the different
> > parts swapped onto it. I don't imagine you will be selling
> > BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your
> > docs and other collateral use "AM67", using the same here
> > would help avoid confusion.
> >
> > Andrew
>
> Andrew, would you like us to model this just like the AM69-SK? and
> also rename the device tree? or just the bindings..
>
> k3-j722s-beagley-ai.dtb -> k3-am67-beagley-ai.dtb or even the am67a
> k3-am67a-beagley-ai.dtb ?

Yes, rename binding and dtb name would be great. Better now then have
the name confuse folks forever.

AM67A is more correct than AM67 (which is the spin without AI), given
this is an AI focused device I'd imagine you'll be using the "a" version.

Andrew

> Regards,