Re: [PATCH 3/4] mfd: intel_quark_i2c_gpio: Utilize i2c-designware.h

From: Florian Fainelli
Date: Tue Apr 23 2024 - 21:28:41 EST




On 4/23/2024 5:01 PM, Andy Shevchenko wrote:
Tue, Apr 23, 2024 at 04:36:21PM -0700, Florian Fainelli kirjoitti:
Rather than open code the i2c_designware string, utilize the newly
defined constant in i2c-designware.h.

...

-#define INTEL_QUARK_I2C_CONTROLLER_CLK "i2c_designware.0"
+#define INTEL_QUARK_I2C_CONTROLLER_CLK I2C_DESIGNWARE_NAME ".0"

So, if you build a module separately for older version of the kernel (assuming
it allows you to modprobe), this won't work anymore.


Sorry not following, was that comment supposed to be for patch #1 where I changed the i2c-designware-pci to i2c_designware-pci? modprobe recognizes both - and _ as interchangeable BTW.
--
Florian

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature