Re: [PATCH 0/7] Use mboxes instead of syscon for APCS (arm32 & arm64)
From: Bjorn Andersson
Date: Wed Apr 24 2024 - 12:55:55 EST
On Wed, Apr 24, 2024 at 06:23:53PM +0200, Luca Weiss wrote:
> The first patch is for removing a bogus error warning I've noticed while
> developing this on msm8226 - there the patches are also coming later for
> this SoC since apcs is getting hooked up to cpufreq there also.
>
> Apart from usages from the qcom,smsm driver (patches coming!) all other
> usages of the apcs mailbox now go via the mailbox driver - where one is
> used, so some arm32 boards will continue using "qcom,ipc*" properties in
> the short or long term.
>
Very nice, thank you for cleaning this up.
Regards,
Bjorn
> Only compile-tested apart from msm8953 (tested on sdm632-fairphone-fp3)
> and msm8974 (tested on msm8974pro-fairphone-fp2), but I don't expect any
> complications with this.
>
> Signed-off-by: Luca Weiss <luca@xxxxxxxxx>
> ---
> Luca Weiss (7):
> rpmsg: qcom_smd: Don't print error during probe deferral
> ARM: dts: qcom: msm8974: Use mboxes properties for APCS
> arm64: dts: qcom: msm8916: Use mboxes properties for APCS
> arm64: dts: qcom: msm8939: Use mboxes properties for APCS
> arm64: dts: qcom: msm8953: Use mboxes properties for APCS
> arm64: dts: qcom: msm8976: Use mboxes properties for APCS
> arm64: dts: qcom: msm8994: Use mboxes properties for APCS
>
> arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 14 +++++++-------
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 10 +++++-----
> arch/arm64/boot/dts/qcom/msm8939.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/msm8953.dtsi | 10 +++++-----
> arch/arm64/boot/dts/qcom/msm8976.dtsi | 8 ++++----
> arch/arm64/boot/dts/qcom/msm8994.dtsi | 6 +++---
> drivers/rpmsg/qcom_smd.c | 3 ++-
> 7 files changed, 28 insertions(+), 27 deletions(-)
> ---
> base-commit: 43173e6dbaa227f3107310d4df4a3bacd5e0df33
> change-id: 20240423-apcs-mboxes-12ee6c01a5b3
>
> Best regards,
> --
> Luca Weiss <luca@xxxxxxxxx>
>