Re: [PATCH net-next v2 2/2] net: dsa: Remove adjust_link paths

[Florian Fainelli]

On 4/29/24 13:00, Simon Horman wrote:
> On Mon, Apr 29, 2024 at 09:54:05AM -0700, Florian Fainelli wrote:
> > Now that we no longer any drivers using PHYLIB's adjust_link callback,
> > remove all paths that made use of adjust_link as well as the associated
> > functions.
> >
> > Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
>
> ...
>
> > @@ -1616,17 +1597,13 @@ static void dsa_port_phylink_mac_link_down(struct phylink_config *config,
> >   					   phy_interface_t interface)
> >   {
> >   	struct dsa_port *dp = dsa_phylink_to_port(config);
> > -	struct phy_device *phydev = NULL;
>
> Hi Florian,
>
> I'm wondering if some changes got lost somewhere.
>
> phydev is removed here...
>
> >   	struct dsa_switch *ds = dp->ds;
> >   
> >   	if (dsa_port_is_user(dp))
> >   		phydev = dp->user->phydev;
>
> ... assigned here, but not used.
>
> Perhaps the three lines above should be removed?

Yes, sorry about that, rebase gone wrong on my side.
--
Florian

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature