Re: [PATCH 01/52] USB: serial: store owner from modules with usb_serial_register_drivers()

[Krzysztof Kozlowski]

On 15/04/2024 10:56, Johan Hovold wrote:
> On Thu, Mar 28, 2024 at 11:05:39PM +0100, Krzysztof Kozlowski wrote:
>> Modules registering driver with usb_serial_register_drivers() might
>> forget to set .owner field.  The field is used by some of other kernel
>> parts for reference counting (try_module_get()), so it is expected that
>> drivers will set it.
>>
>> Solve the problem by moving this task away from the drivers to the core
>> amba bus code, just like we did for platform_driver in
> 
> "amba"
> 
>> commit 9447057eaff8 ("platform_device: use a macro instead of
>> platform_driver_register").
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>>  drivers/usb/serial/usb-serial.c | 12 +++++++-----
>>  include/linux/usb/serial.h      |  7 +++++--
>>  2 files changed, 12 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
>> index f1e91eb7f8a4..a659f2096a1a 100644
>> --- a/drivers/usb/serial/usb-serial.c
>> +++ b/drivers/usb/serial/usb-serial.c
>> @@ -1459,17 +1459,18 @@ static void usb_serial_deregister(struct usb_serial_driver *device)
>>  }
>>  
>>  /**
>> - * usb_serial_register_drivers - register drivers for a usb-serial module
>> + * __usb_serial_register_drivers - register drivers for a usb-serial module
>>   * @serial_drivers: NULL-terminated array of pointers to drivers to be registered
>> + * @owner: owning module/driver
> 
> Just "module"

Ack for both.

Best regards,
Krzysztof