Re: [PATCH wireless-next v2] wifi: ath12k: allocate dummy net_device dynamically
From: Simon Horman
Date: Wed May 08 2024 - 11:12:35 EST
On Wed, May 08, 2024 at 02:54:09AM -0700, Breno Leitao wrote:
> Embedding net_device into structures prohibits the usage of flexible
> arrays in the net_device structure. For more details, see the discussion
> at [1].
>
> Un-embed the net_device from struct ath12k_ext_irq_grp by converting it
> into a pointer. Then use the leverage alloc_netdev_dummy() to allocate
> the net_device object at ath12k_pci_ext_irq_config().
>
> The free of the device occurs at ath12k_pci_free_ext_irq().
>
> [1] https://lore.kernel.org/all/20240229225910.79e224cf@xxxxxxxxxx/
>
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
> ---
> Changelog:
> v2:
> * Free all the allocated dummy devices if one of them fails to
> be allocated (in ath12k_pci_ext_irq_config()), as
> pointed by by Simon Horman.
Thanks for the update.
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>