Re: [PATCH v2 4/6] KVM: arm64: add emulation for CTR_EL0 register

[Sebastian Ott]

Hej Oliver,

On Wed, 1 May 2024, Oliver Upton wrote:
> > +static u64 reset_ctr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd)
> > +{
> > +	vcpu->kvm->arch.ctr_el0 = read_sanitised_ftr_reg(SYS_CTR_EL0);
> > +	return vcpu->kvm->arch.ctr_el0;
> > +}
> > +
>
> We definitely do not want this value to change across a vCPU reset, it
> should be handled like the other ID registers where they only get reset
> once for the VM lifetime.

Hm, maybe I'm misreading the code here but I don't think this is true
for existing regs e.g. CLIDR_EL1 or the stuff defined via ID_WRITABLE().

Sebastian