Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE_ALIAS

From: Andy Shevchenko
Date: Wed May 08 2024 - 14:29:14 EST


On Wed, May 08, 2024 at 08:15:00PM +0200, Krzysztof Kozlowski wrote:
> On 08/05/2024 19:53, Andy Shevchenko wrote:
> > On Sun, Apr 14, 2024 at 05:49:57PM +0200, Krzysztof Kozlowski wrote:
> >> The ID table already has respective entry and MODULE_DEVICE_TABLE and
> >> creates proper alias for SPI driver. Having another MODULE_ALIAS causes
> >> the alias to be duplicated.

..

> >> MODULE_ALIAS("spi:93xx46");
> >
> > I was stumbled over this (leftover?).
> > Commit message doesn't elaborate this bit.
> > Any comments?
>
> It is not present in ID table and commit msg removes only duplicated
> aliases. That alias has meaning - someone might be actually relying on it.

It seems no users for it. The only user of platform data of this EEPROM uses
board files which AFAIU bypasses modalias matching.

--
With Best Regards,
Andy Shevchenko