Re: [PATCH] riscv: Don't use hugepage mappings for vmemmap if it's not supported

From: Nam Cao
Date: Wed May 08 2024 - 14:47:07 EST


On Wed, May 08, 2024 at 08:22:43PM +0200, Alexandre Ghiti wrote:
> Hi Nam,
Hi Alex,

> > Commit ff172d4818ad ("riscv: Use hugepage mappings for vmemmap") broke XIP
> > kernel, because huge pages are not supported on XIP kernel.
>
> I don't understand why XIP kernels can't support huge vmalloc mappings,

Me neither.

> so I
> think the right fix would be to enable such mappings on XIP. WDYT?

I agree that is the ideal solution. But I don't want to send any new
feature to the stable trees (stable folks may even reject such patch).
So I intend that to be in another patch.

Best regards,
Nam