Re: [PATCH v21 07/39] ASoC: Add SOC USB APIs for adding an USB backend

[Wesley Cheng]

Hi Pierre,

On 5/7/2024 1:26 PM, Pierre-Louis Bossart wrote:
> > +const char *snd_soc_usb_get_components_tag(bool playback)
> > +{
> > +	if (playback)
> > +		return "usbplaybackoffload: 1";
> > +	else
> > +		return "usbcaptureoffload : 1";
>
> why are there different spaces and do we need spaces in the first place?

Will remove these spaces once we clarify if this is still needed.

> > +int snd_soc_usb_add_port(struct snd_soc_usb *usb)
> > +{
> > +	mutex_lock(&ctx_mutex);
> > +	list_add_tail(&usb->list, &usb_ctx_list);
> > +	mutex_unlock(&ctx_mutex);
> > +
> > +	return 0;
>
> make the function return void?

Ack.

> > +int snd_soc_usb_remove_port(struct snd_soc_usb *usb)
> > +{
> > +	struct snd_soc_usb *ctx, *tmp;
> > +
> > +	mutex_lock(&ctx_mutex);
> > +	list_for_each_entry_safe(ctx, tmp, &usb_ctx_list, list) {
> > +		if (ctx == usb) {
> > +			list_del(&ctx->list);
> > +			break;
> > +		}
> > +	}
> > +	mutex_unlock(&ctx_mutex);
> > +
> > +	return 0;
>
> make this return void?

Ack.

Thanks
Wesley Cheng