RE: [PATCH v3] watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate a safety margin
From: Saulnier, Nick
Date: Wed May 08 2024 - 16:32:50 EST
Tested on my side with the default 50% window across a range of periods. Works as expected. Details at
https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1338070/am625-how-to-control-the-watchdog/5166032#5166032
Regards,
Nick Saulnier
-----Original Message-----
From: Mendez, Judith
Sent: Wednesday, May 08, 2024 1:50 PM
To: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>; Guenter Roeck <linux@xxxxxxxxxxxx>
Cc: linux-watchdog@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Rafael Beims <rafael.beims@xxxxxxxxxxx>; Raghavendra, Vignesh <vigneshr@xxxxxx>; Saulnier, Nick <nsaulnier@xxxxxx>
Subject: Re: [PATCH v3] watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate a safety margin
Hi all,
On 4/17/24 3:57 PM, Judith Mendez wrote:
> On AM62x, the watchdog is pet before the valid window is open. Fix
> min_hw_heartbeat and accommodate a 2% + static offset safety margin.
> The static offset accounts for max hardware error.
>
> Remove the hack in the driver which shifts the open window boundary,
> since it is no longer necessary due to the fix mentioned above.
>
This patch has been sitting and there are no comments.
Please let me know if there is any issue with this patch, since I would like to get this fix merged (:
Thanks,
Judith