Re: [PATCH] perf dwarf-aux: Fix build with HAVE_DWARF_CFI_SUPPORT

From: Namhyung Kim
Date: Wed May 08 2024 - 17:11:07 EST


On Wed, May 8, 2024 at 2:05 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> On Wed, May 8, 2024 at 7:15 AM James Clark <james.clark@xxxxxxx> wrote:
> >
> > check_allowed_ops() is used from both HAVE_DWARF_GETLOCATIONS_SUPPORT
> > and HAVE_DWARF_CFI_SUPPORT sections, so move it into the right place so
> > that it's available when either are defined. This shows up when doing
> > a static cross compile for arm64:
> >
> > $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- LDFLAGS="-static" \
> > EXTRA_PERFLIBS="-lexpat"
> >
> > util/dwarf-aux.c:1723:6: error: implicit declaration of function 'check_allowed_ops'
> >
> > Fixes: 55442cc2f22d ("perf dwarf-aux: Check allowed DWARF Ops")
> > Signed-off-by: James Clark <james.clark@xxxxxxx>
>
> Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>
> (eye-balled to see the #if problem exists and this is the correct fix)

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung