[PATCH v2 2/2] drm/panel: starry: add new panel driver
From: Zhaoxiong Lv
Date: Thu May 09 2024 - 04:40:08 EST
The starry panel is based on ER88577 controller.
Add a driver for it.
Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
---
Chage since V2:
- add the Makefile and Kconfig files
V1: https://lore.kernel.org/all/20240509064959.23550-3-lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
---
drivers/gpu/drm/panel/Kconfig | 9 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-starry-er88577.c | 444 +++++++++++++++++++
3 files changed, 454 insertions(+)
create mode 100644 drivers/gpu/drm/panel/panel-starry-er88577.c
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 2c73086cf102..c075b1875ca6 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -795,6 +795,15 @@ config DRM_PANEL_SONY_TULIP_TRULY_NT35521
NT35521 1280x720 video mode panel as found on Sony Xperia M4
Aqua phone.
+config DRM_PANEL_STARRY_ER88577
+ tristate "Starry er88577 panel"
+ depends on OF
+ depends on DRM_MIPI_DSI
+ depends on BACKLIGHT_CLASS_DEVICE
+ help
+ Say Y if you want to enable support for panels based on the
+ Starry er88577 controller.
+
config DRM_PANEL_STARTEK_KD070FHFID015
tristate "STARTEK KD070FHFID015 panel"
depends on OF
diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
index cbd414b98bb0..d18917e0e192 100644
--- a/drivers/gpu/drm/panel/Makefile
+++ b/drivers/gpu/drm/panel/Makefile
@@ -80,6 +80,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += panel-sharp-ls060t1sx01.o
obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o
obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o
obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o
+obj-$(CONFIG_DRM_PANEL_STARRY_ER88577) += panel-starry-er88577.o
obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o
obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o
obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) += panel-sony-td4353-jdi.o
diff --git a/drivers/gpu/drm/panel/panel-starry-er88577.c b/drivers/gpu/drm/panel/panel-starry-er88577.c
new file mode 100644
index 000000000000..dfeae549adc5
--- /dev/null
+++ b/drivers/gpu/drm/panel/panel-starry-er88577.c
@@ -0,0 +1,444 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Panels based on the ER88577B display controller.
+ * Author: Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
+ */
+
+#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/regulator/consumer.h>
+
+#include <drm/drm_connector.h>
+#include <drm/drm_crtc.h>
+#include <drm/drm_mipi_dsi.h>
+#include <drm/drm_panel.h>
+
+#include <video/mipi_display.h>
+
+struct panel_desc {
+ const struct drm_display_mode *modes;
+ unsigned int bpc;
+
+ /**
+ * @width_mm: width of the panel's active display area
+ * @height_mm: height of the panel's active display area
+ */
+ struct {
+ unsigned int width_mm;
+ unsigned int height_mm;
+ } size;
+
+ unsigned long mode_flags;
+ enum mipi_dsi_pixel_format format;
+ const struct panel_init_cmd *init_cmds;
+ unsigned int lanes;
+ bool discharge_on_disable;
+ bool lp11_before_reset;
+};
+
+struct starry_panel {
+ struct drm_panel base;
+ struct mipi_dsi_device *dsi;
+
+ const struct panel_desc *desc;
+
+ enum drm_panel_orientation orientation;
+ struct regulator *pp3300;
+ struct gpio_desc *enable_gpio;
+};
+
+enum dsi_cmd_type {
+ INIT_DCS_CMD,
+ DELAY_CMD,
+};
+
+struct panel_init_cmd {
+ enum dsi_cmd_type type;
+ size_t len;
+ const char *data;
+};
+
+#define _INIT_DCS_CMD(...) { \
+ .type = INIT_DCS_CMD, \
+ .len = sizeof((char[]){__VA_ARGS__}), \
+ .data = (char[]){__VA_ARGS__} }
+
+#define _INIT_DELAY_CMD(...) { \
+ .type = DELAY_CMD,\
+ .len = sizeof((char[]){__VA_ARGS__}), \
+ .data = (char[]){__VA_ARGS__} }
+
+static const struct panel_init_cmd starry_er88577_init_cmd[] = {
+ _INIT_DELAY_CMD(120),
+ _INIT_DCS_CMD(0xE0, 0xAB, 0xBA),
+ _INIT_DCS_CMD(0xE1, 0xBA, 0xAB),
+ _INIT_DCS_CMD(0xB1, 0x10, 0x01, 0x47, 0xFF),
+ _INIT_DCS_CMD(0xB2, 0x0C, 0x14, 0x04, 0x50, 0x50, 0x14),
+ _INIT_DCS_CMD(0xB3, 0x56, 0x53, 0x00),
+ _INIT_DCS_CMD(0xB4, 0x33, 0x30, 0x04),
+ _INIT_DCS_CMD(0xB6, 0xB0, 0x00, 0x00, 0x10, 0x00, 0x10, 0x00),
+ _INIT_DCS_CMD(0xB8, 0x05, 0x12, 0x29, 0x49, 0x40),
+ _INIT_DCS_CMD(0xB9, 0x7C, 0x61, 0x4F, 0x42, 0x3E, 0x2D, 0x31, 0x1A, 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, 0x0E, 0x06, 0x7C, 0x61, 0x4F, 0x42, 0x3E, 0x2D, 0x31, 0x1A, 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, 0x0E, 0x06),
+ _INIT_DCS_CMD(0xC0, 0xCC, 0x76, 0x12, 0x34, 0x44, 0x44, 0x44, 0x44, 0x98, 0x04, 0x98, 0x04, 0x0F, 0x00, 0x00, 0xC1),
+ _INIT_DCS_CMD(0xC1, 0x54, 0x94, 0x02, 0x85, 0x9F, 0x00, 0x6F, 0x00, 0x54, 0x00),
+ _INIT_DCS_CMD(0xC2, 0x17, 0x09, 0x08, 0x89, 0x08, 0x11, 0x22, 0x20, 0x44, 0xFF, 0x18, 0x00),
+ _INIT_DCS_CMD(0xC3, 0x87, 0x47, 0x05, 0x05, 0x1C, 0x1C, 0x1D, 0x1D, 0x02, 0x1E, 0x1E, 0x1F, 0x1F, 0x0F, 0x0F, 0x0D, 0x0D, 0x13, 0x13, 0x11, 0x11, 0x24),
+ _INIT_DCS_CMD(0xC4, 0x06, 0x06, 0x04, 0x04, 0x1C, 0x1C, 0x1D, 0x1D, 0x02, 0x1E, 0x1E, 0x1F, 0x1F, 0x0E, 0x0E, 0x0C, 0x0C, 0x12, 0x12, 0x10, 0x10, 0x24),
+
+ _INIT_DCS_CMD(0xC8, 0x21, 0x00, 0x31, 0x42, 0x34, 0x16),
+ _INIT_DCS_CMD(0xCA, 0xCB, 0x43),
+ _INIT_DCS_CMD(0xCD, 0x0E, 0x4B, 0x4B, 0x20, 0x19, 0x6B, 0x06, 0xB3),
+ _INIT_DCS_CMD(0xD2, 0xE3, 0x2B, 0x38, 0x08),
+ _INIT_DCS_CMD(0xD4, 0x00, 0x01, 0x00, 0x0E, 0x04, 0x44, 0x08, 0x10, 0x00, 0x00, 0x00),
+ _INIT_DCS_CMD(0xE6, 0x80, 0x09, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF),
+ _INIT_DCS_CMD(0xF0, 0x12, 0x03, 0x20, 0x00, 0xFF),
+ _INIT_DCS_CMD(0xF3, 0x00),
+
+ _INIT_DCS_CMD(0X11),
+ _INIT_DELAY_CMD(120),
+ _INIT_DCS_CMD(0X29),
+ _INIT_DELAY_CMD(20),
+ {},
+};
+
+static inline struct starry_panel *to_starry_panel(struct drm_panel *panel)
+{
+ return container_of(panel, struct starry_panel, base);
+}
+
+static int starry_panel_init_dcs_cmd(struct starry_panel *starry)
+{
+ struct mipi_dsi_device *dsi = starry->dsi;
+ struct drm_panel *panel = &starry->base;
+ int i, err = 0;
+
+ if (starry->desc->init_cmds) {
+ const struct panel_init_cmd *init_cmds = starry->desc->init_cmds;
+
+ for (i = 0; init_cmds[i].len != 0; i++) {
+ const struct panel_init_cmd *cmd = &init_cmds[i];
+
+ switch (cmd->type) {
+ case DELAY_CMD:
+ msleep(cmd->data[0]);
+ err = 0;
+ break;
+
+ case INIT_DCS_CMD:
+ err = mipi_dsi_dcs_write(dsi, cmd->data[0],
+ cmd->len <= 1 ? NULL :
+ &cmd->data[1],
+ cmd->len - 1);
+ break;
+
+ default:
+ err = -EINVAL;
+ }
+
+ if (err < 0) {
+ dev_err(panel->dev,
+ "failed to write command %u\n", i);
+ return err;
+ }
+ }
+ }
+ return 0;
+}
+
+static int starry_panel_enter_sleep_mode(struct starry_panel *starry)
+{
+ struct mipi_dsi_device *dsi = starry->dsi;
+ int ret;
+
+ dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
+
+ usleep_range(1000, 2000);
+
+ ret = mipi_dsi_dcs_set_display_off(dsi);
+ if (ret < 0)
+ return ret;
+
+ ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
+ if (ret < 0)
+ return ret;
+
+ return 0;
+}
+
+static int starry_panel_disable(struct drm_panel *panel)
+{
+ struct starry_panel *starry = to_starry_panel(panel);
+ int ret;
+
+ ret = starry_panel_enter_sleep_mode(starry);
+ if (ret < 0) {
+ dev_err(panel->dev, "failed to set panel off: %d\n", ret);
+ return ret;
+ }
+
+ msleep(120);
+
+ return 0;
+}
+
+static int starry_panel_unprepare(struct drm_panel *panel)
+{
+ struct starry_panel *starry = to_starry_panel(panel);
+ int err;
+/*
+ err = mipi_dsi_dcs_enter_sleep_mode(starry->dsi);
+ if (err < 0) {
+ dev_err(panel->dev, "failed to enter sleep mode: %d\n", err);
+ return err;
+ }
+*/
+ gpiod_set_value_cansleep(starry->enable_gpio, 0);
+
+ /* T15: 2ms */
+ usleep_range(1000, 2000);
+
+ err = regulator_disable(starry->pp3300);
+ if (err < 0)
+ return err;
+
+ return 0;
+}
+
+static int starry_panel_prepare(struct drm_panel *panel)
+{
+ struct starry_panel *starry = to_starry_panel(panel);
+ int ret;
+
+ gpiod_set_value(starry->enable_gpio, 0);
+
+ printk(KERN_ERR "lvzhaoxiong--1");
+
+ ret = regulator_enable(starry->pp3300);
+ if (ret < 0)
+ return ret;
+
+ /* T1: 5ms */
+ usleep_range(5000, 6000);
+
+ if (starry->desc->lp11_before_reset) {
+ mipi_dsi_dcs_nop(starry->dsi);
+ usleep_range(1000, 2000);
+ }
+ printk(KERN_ERR "lvzhaoxiong--3");
+
+ /* T: 60ms*/
+ msleep(60);
+
+ gpiod_set_value_cansleep(starry->enable_gpio, 1);
+
+ ret = starry_panel_init_dcs_cmd(starry);
+ if (ret < 0) {
+ dev_err(panel->dev, "failed to init panel: %d\n", ret);
+ goto poweroff;
+ }
+ printk(KERN_ERR "lvzhaoxiong--3");
+
+ return 0;
+
+poweroff:
+ regulator_disable(starry->pp3300);
+ /* T6: 2ms */
+ usleep_range(1000, 2000);
+ gpiod_set_value(starry->enable_gpio, 0);
+
+ return ret;
+}
+
+static int starry_panel_enable(struct drm_panel *panel)
+{
+ msleep(130);
+ return 0;
+}
+
+static const struct drm_display_mode starry_er88577_default_mode = {
+ .clock = 77380,
+ .hdisplay = 800,
+ .hsync_start = 800 + 80,
+ .hsync_end = 800 + 80 + 20,
+ .htotal = 800 + 80 + 20 + 80,
+ .vdisplay = 1280,
+ .vsync_start = 1280 + 20,
+ .vsync_end = 1280 + 20 + 4,
+ .vtotal = 1280 + 20 + 4 + 12,
+ .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
+};
+
+static const struct panel_desc starry_er88577_desc = {
+ .modes = &starry_er88577_default_mode,
+ .bpc = 8,
+ .size = {
+ .width_mm = 135,
+ .height_mm = 216,
+ },
+ .lanes = 4,
+ .format = MIPI_DSI_FMT_RGB888,
+ .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
+ MIPI_DSI_MODE_LPM,
+ .init_cmds = starry_er88577_init_cmd,
+ .lp11_before_reset = true,
+};
+
+static int starry_panel_get_modes(struct drm_panel *panel,
+ struct drm_connector *connector)
+{
+ struct starry_panel *starry = to_starry_panel(panel);
+ const struct drm_display_mode *m = starry->desc->modes;
+ struct drm_display_mode *mode;
+
+ mode = drm_mode_duplicate(connector->dev, m);
+ if (!mode) {
+ dev_err(panel->dev, "failed to add mode %ux%u@%u\n",
+ m->hdisplay, m->vdisplay, drm_mode_vrefresh(m));
+ return -ENOMEM;
+ }
+
+ mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
+ drm_mode_set_name(mode);
+ drm_mode_probed_add(connector, mode);
+
+ connector->display_info.width_mm = starry->desc->size.width_mm;
+ connector->display_info.height_mm = starry->desc->size.height_mm;
+ connector->display_info.bpc = starry->desc->bpc;
+
+ return 1;
+}
+
+static enum drm_panel_orientation starry_panel_get_orientation(struct drm_panel *panel)
+{
+ struct starry_panel *starry = to_starry_panel(panel);
+
+ return starry->orientation;
+}
+
+static const struct drm_panel_funcs starry_panel_funcs = {
+ .disable = starry_panel_disable,
+ .unprepare = starry_panel_unprepare,
+ .prepare = starry_panel_prepare,
+ .enable = starry_panel_enable,
+ .get_modes = starry_panel_get_modes,
+ .get_orientation = starry_panel_get_orientation,
+};
+
+static int starry_panel_add(struct starry_panel *starry)
+{
+ struct device *dev = &starry->dsi->dev;
+ int err;
+
+ starry->pp3300 = devm_regulator_get(dev, "pp3300");
+ if (IS_ERR(starry->pp3300))
+ return PTR_ERR(starry->pp3300);
+
+
+ starry->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
+ if (IS_ERR(starry->enable_gpio)) {
+ dev_err(dev, "cannot get reset-gpios %ld\n",
+ PTR_ERR(starry->enable_gpio));
+ return PTR_ERR(starry->enable_gpio);
+ }
+
+ gpiod_set_value(starry->enable_gpio, 0);
+
+ drm_panel_init(&starry->base, dev, &starry_panel_funcs,
+ DRM_MODE_CONNECTOR_DSI);
+ err = of_drm_get_panel_orientation(dev->of_node, &starry->orientation);
+ if (err < 0) {
+ dev_err(dev, "%pOF: failed to get orientation %d\n", dev->of_node, err);
+ return err;
+ }
+
+ err = drm_panel_of_backlight(&starry->base);
+ if (err)
+ return err;
+
+ starry->base.funcs = &starry_panel_funcs;
+ starry->base.dev = &starry->dsi->dev;
+
+ drm_panel_add(&starry->base);
+
+ return 0;
+}
+
+static int starry_panel_probe(struct mipi_dsi_device *dsi)
+{
+ struct starry_panel *starry;
+ int ret;
+ const struct panel_desc *desc;
+
+ starry = devm_kzalloc(&dsi->dev, sizeof(*starry), GFP_KERNEL);
+ if (!starry)
+ return -ENOMEM;
+
+ desc = of_device_get_match_data(&dsi->dev);
+ dsi->lanes = desc->lanes;
+ dsi->format = desc->format;
+ dsi->mode_flags = desc->mode_flags;
+ starry->desc = desc;
+ starry->dsi = dsi;
+ ret = starry_panel_add(starry);
+ if (ret < 0)
+ return ret;
+
+ mipi_dsi_set_drvdata(dsi, starry);
+
+ ret = mipi_dsi_attach(dsi);
+ if (ret)
+ drm_panel_remove(&starry->base);
+
+ printk(KERN_ERR "lvzhaoxiong--0");
+
+ return ret;
+}
+
+static void starry_panel_shutdown(struct mipi_dsi_device *dsi)
+{
+ struct starry_panel *starry = mipi_dsi_get_drvdata(dsi);
+
+ drm_panel_disable(&starry->base);
+ drm_panel_unprepare(&starry->base);
+}
+
+static void starry_panel_remove(struct mipi_dsi_device *dsi)
+{
+ struct starry_panel *starry = mipi_dsi_get_drvdata(dsi);
+ int ret;
+
+ starry_panel_shutdown(dsi);
+
+ ret = mipi_dsi_detach(dsi);
+ if (ret < 0)
+ dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret);
+
+ if (starry->base.dev)
+ drm_panel_remove(&starry->base);
+}
+
+static const struct of_device_id starry_of_match[] = {
+ { .compatible = "starry,er88577",
+ .data = &starry_er88577_desc
+ },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, starry_of_match);
+
+static struct mipi_dsi_driver starry_panel_driver = {
+ .driver = {
+ .name = "panel-starry-er88577",
+ .of_match_table = starry_of_match,
+ },
+ .probe = starry_panel_probe,
+ .remove = starry_panel_remove,
+ .shutdown = starry_panel_shutdown,
+};
+module_mipi_dsi_driver(starry_panel_driver);
+
+MODULE_AUTHOR("Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>");
+MODULE_DESCRIPTION("starry er88577b 800x1280 video mode panel driver");
+MODULE_LICENSE("GPL v2");
--
2.17.1