Re: [PATCH] dt-bindings: leds: mark label as depected to match description
From: Pavel Machek
Date: Thu May 09 2024 - 12:55:24 EST
On Thu 2024-05-09 14:39:36, AngeloGioacchino Del Regno wrote:
> Il 09/05/24 13:46, Krzysztof Kozlowski ha scritto:
> > On 09/05/2024 13:05, Frank Wunderlich wrote:
> > > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > >
> > > The description for property 'label' describes it as deprected, so
> >
> > Typos here and in subject.
> >
> >
> > > add a option to mark it like that. Future devicetrees should use
> > > function and color properties.
> > >
> > > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > > Fixes: 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema")
> >
> > Nooo, that's not a fix.
> >
> > I don't think there was conclusion to make it deprecated on last attempt:
> >
> > https://lore.kernel.org/all/20221122111124.6828-1-cniedermaier@xxxxxxxxxxxxxxxxxx/
> >
>
> It's not a fix, agreed.
>
> But that property being deprecated deserves to be marked as deprecated, anyway.
> Otherwise the documentation shouldn't say in words that it is such.
Fix the docs. We are not ready to deprecate that.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
Attachment:
signature.asc
Description: PGP signature