Re: [External] : [PATCH 1/2] tcp: fix get_tcp4_sock() output error info

[Eric Dumazet]

On Thu, May 9, 2024 at 8:09 PM David Wei <dw@xxxxxxxxxxx> wrote:
>
> On 2024-05-09 10:29, Mohith Kumar Thummaluru wrote:
> > Good catch! Thanks for this fix.
>
> If this is a fix, can you please add a Fixes tag? And in general some
> surrounding context in a cover letter? Thanks.


I do not think it is a fix, and I am not sure we want this patch anyway.

/proc interface is legacy, we do not change it.

Please use TCP_INFO or inet_diag, because
commit 5ee3afba88f5 "[TCP]: Return useful listenq info in tcp_info and
INET_DIAG_INFO."
took care of this in 2007.

Already in 2007 we were considering /proc/net/tcp as a legacy.