Re: [PATCH net-next v2 1/3] net: dsa: microchip: dcb: rename IPV to IPM
From: Jakub Kicinski
Date: Thu May 09 2024 - 23:43:38 EST
On Thu, 9 May 2024 07:33:33 +0200 Oleksij Rempel wrote:
> IPV is added and used term in 802.1Qci PSFP and merged into 802.1Q (from
> 802.1Q-2018) for another functions.
>
> Even it does similar operation holding temporal priority value
> internally (as it is named), because KSZ datasheet doesn't use the term
> of IPV (Internal Priority Value) and avoiding any confusion later when
> PSFP is in the Linux world, it is better to rename IPV to IPM (Internal
> Priority Mapping).
>
> In addition, LAN937x documentation already use IPV for 802.1Qci PSFP
> related functionality.
Transient build failure here:
drivers/net/dsa/microchip/ksz_dcb.c: In function ‘ksz_set_global_dscp_entry’:
drivers/net/dsa/microchip/ksz_dcb.c:323:25: error: ‘ipm’ undeclared (first use in this function); did you mean ‘ipv’?
323 | ipm << shift);
| ^~~
| ipv
--
pw-bot: cr