Re: [PATCH V1 6/9] PCI/TPH: Retrieve steering tag from ACPI _DSM

From: kernel test robot
Date: Fri May 10 2024 - 00:21:06 EST


Hi Wei,

kernel test robot noticed the following build errors:

[auto build test ERROR on pci/for-linus]
[also build test ERROR on awilliam-vfio/next linus/master awilliam-vfio/for-linus v6.9-rc7 next-20240509]
[cannot apply to pci/next horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Wei-Huang/PCI-Introduce-PCIe-TPH-support-framework/20240510-003504
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git for-linus
patch link: https://lore.kernel.org/r/20240509162741.1937586-7-wei.huang2%40amd.com
patch subject: [PATCH V1 6/9] PCI/TPH: Retrieve steering tag from ACPI _DSM
config: parisc-randconfig-r081-20240510 (https://download.01.org/0day-ci/archive/20240510/202405101200.FPuliW1p-lkp@xxxxxxxxx/config)
compiler: hppa-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240510/202405101200.FPuliW1p-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405101200.FPuliW1p-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

drivers/pci/pcie/tph.c: In function 'tph_msix_table_entry':
drivers/pci/pcie/tph.c:95:22: error: 'struct pci_dev' has no member named 'msix_base'; did you mean 'msix_cap'?
95 | entry = dev->msix_base + msi_index * PCI_MSIX_ENTRY_SIZE;
| ^~~~~~~~~
| msix_cap
drivers/pci/pcie/tph.c: In function 'invoke_dsm':
>> drivers/pci/pcie/tph.c:221:46: error: 'pci_acpi_dsm_guid' undeclared (first use in this function)
221 | out_obj = acpi_evaluate_dsm(handle, &pci_acpi_dsm_guid, MIN_ST_DSM_REV,
| ^~~~~~~~~~~~~~~~~
drivers/pci/pcie/tph.c:221:46: note: each undeclared identifier is reported only once for each function it appears in


vim +/pci_acpi_dsm_guid +221 drivers/pci/pcie/tph.c

196
197 #define MIN_ST_DSM_REV 7
198 #define ST_DSM_FUNC_INDEX 0xf
199 static bool invoke_dsm(acpi_handle handle, u32 cpu_uid, u8 ph,
200 u8 target_type, bool cache_ref_valid,
201 u64 cache_ref, union st_info *st_out)
202 {
203 union acpi_object in_obj, in_buf[3], *out_obj;
204
205 in_buf[0].integer.type = ACPI_TYPE_INTEGER;
206 in_buf[0].integer.value = 0; /* 0 => processor cache steering tags */
207
208 in_buf[1].integer.type = ACPI_TYPE_INTEGER;
209 in_buf[1].integer.value = cpu_uid;
210
211 in_buf[2].integer.type = ACPI_TYPE_INTEGER;
212 in_buf[2].integer.value = ph & 3;
213 in_buf[2].integer.value |= (target_type & 1) << 2;
214 in_buf[2].integer.value |= (cache_ref_valid & 1) << 3;
215 in_buf[2].integer.value |= (cache_ref << 32);
216
217 in_obj.type = ACPI_TYPE_PACKAGE;
218 in_obj.package.count = ARRAY_SIZE(in_buf);
219 in_obj.package.elements = in_buf;
220
> 221 out_obj = acpi_evaluate_dsm(handle, &pci_acpi_dsm_guid, MIN_ST_DSM_REV,
222 ST_DSM_FUNC_INDEX, &in_obj);
223
224 if (!out_obj)
225 return false;
226
227 if (out_obj->type != ACPI_TYPE_BUFFER) {
228 pr_err("invalid return type %d from TPH _DSM\n",
229 out_obj->type);
230 ACPI_FREE(out_obj);
231 return false;
232 }
233
234 st_out->value = *((u64 *)(out_obj->buffer.pointer));
235
236 ACPI_FREE(out_obj);
237
238 return true;
239 }
240

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki