Re: [PATCH v2 10/10] s390/hugetlb: convert PG_arch_1 code to work on folio->flags

[Claudio Imbrenda]

On Wed, 8 May 2024 20:08:07 +0200
David Hildenbrand <david@xxxxxxxxxx> wrote:

> On 07.05.24 18:33, Claudio Imbrenda wrote:
> > On Fri, 12 Apr 2024 16:21:20 +0200
> > David Hildenbrand <david@xxxxxxxxxx> wrote:
> >   
> >> Let's make it clearer that we are always working on folio flags and
> >> never page flags of tail pages.  
> > 
> > please be a little more verbose, and explain what you are doing (i.e.
> > converting usages of page flags to folio flags), not just why.
> >   
> >>
> >> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>  
> > 
> > with a few extra words in the description:  
> 
>      Let's make it clearer that we are always working on folio flags and
>      never page flags of tail pages by converting remaining PG_arch_1 users
>      that modify page->flags to modify folio->flags instead.
>      
>      No functional change intended, because we would always have worked with
>      the head page (where page->flags corresponds to folio->flags) and never
>      with tail pages.

this works, thanks!

> 
> 
> > 
> > Reviewed-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>  
> 
> Thanks for all the review!
>