Re: [PATCH bpf-next v2 2/4] selftests/bpf/sockopt: Add a null pointer check for the run_test

[Muhammad Usama Anjum]

On 5/10/24 2:58 PM, kunwu.chan@xxxxxxxxx wrote:
> From: Kunwu Chan <chentao@xxxxxxxxxx>
> 
> There is a 'malloc' call, which can be unsuccessful.
> Add the malloc failure checking to avoid possible null
> dereference and give more information
> about test fail reasons.
> 
> Signed-off-by: Kunwu Chan <chentao@xxxxxxxxxx>
LGTM
Reviewed-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>

> ---
>  tools/testing/selftests/bpf/prog_tests/sockopt.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt.c b/tools/testing/selftests/bpf/prog_tests/sockopt.c
> index 5a4491d4edfe..bde63e1f74dc 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sockopt.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sockopt.c
> @@ -1100,6 +1100,12 @@ static int run_test(int cgroup_fd, struct sockopt_test *test, bool use_io_uring)
>  		}
>  
>  		optval = malloc(test->get_optlen);
> +		if (!optval) {
> +			log_err("Failed to allocate memory");
> +			ret = -1;
> +			goto close_sock_fd;
> +		}
> +
>  		memset(optval, 0, test->get_optlen);
>  		socklen_t optlen = test->get_optlen;
>  		socklen_t expected_get_optlen = test->get_optlen_ret ?:

-- 
BR,
Muhammad Usama Anjum