Re: [PATCH v4 0/3] perf probe: Allow names to start with digits

[Arnaldo Carvalho de Melo]

On Fri, May 10, 2024 at 07:24:29AM +0900, Dominique Martinet wrote:
> This is a rebase of the patch orginally sent almost two years ago here:
> https://lkml.kernel.org/r/20220612061508.1449636-1-asmadeus@xxxxxxxxxxxxx
> 
> At the time I was asked to add tests, and Jiri whipped up something to
> make the test pass even for probes that don't exist on most systems but
> that ended up never being formatted or sent... I asked what happened of
> it and got asked to send it myself, but obviously also totally forget
> about it myself until I needed it again now.
> 
> I've taken the diff from that thread, adapted it a little bit to the
> current master branch and checked things still fall in place -- I didn't
> see any obvious problem.

Thanks, applied to perf-tools-next,

- Arnaldo
 
> Thanks!
> 
> To: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> To: Jiri Olsa <jolsa@xxxxxxxxxx>
> To: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> To: Ingo Molnar <mingo@xxxxxxxxxx>
> To: Namhyung Kim <namhyung@xxxxxxxxxx>
> To: Mark Rutland <mark.rutland@xxxxxxx>
> To: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> To: Ian Rogers <irogers@xxxxxxxxxx>
> To: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> To: Liang, Kan <kan.liang@xxxxxxxxxxxxxxx>
> Cc: linux-perf-users@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Dominique Martinet <asmadeus@xxxxxxxxxxxxx>
> 
> Changes in v4:
> - add missing ifdef LIBTRACEEVENT for new test case
> Note build-test still failed on my setup due to some bpf/cgroup problem,
> which is more likely a setup problem but means I couldn't verify build
> all the way:
> util/bpf_skel/bperf_cgroup.bpf.c:71:10: error: incomplete definition of type 'struct cgroup'
> - Link to v3: https://lore.kernel.org/r/20240509-perf_digit-v3-0-9036bf7898da@xxxxxxxxxxxxx
> 
> Changes in v3:
> - fix evsel__newtp_idx typo in commit 1's message
> - rebase onto perf-tools-next
> - add trailers
> - Link to v2: https://lore.kernel.org/r/20240505-perf_digit-v2-0-6ece307fdaad@xxxxxxxxxxxxx
> 
> Changes in v2:
> - update Jiri's email in commit tags
> - (not a change, but after being brain-dead and Ian helpful
> reply I'm confirming patch 3/3 works as expected)
> - Link to v1: https://lore.kernel.org/r/20240407-perf_digit-v1-0-57ec37c63394@xxxxxxxxxxxxx
> 
> ---
> Dominique Martinet (3):
>       perf parse-events: pass parse_state to add_tracepoint
>       perf parse-events: Add new 'fake_tp' parameter for tests
>       perf parse: Allow names to start with digits
> 
>  tools/perf/tests/parse-events.c | 13 +++++++++++--
>  tools/perf/tests/pmu-events.c   |  2 +-
>  tools/perf/util/evlist.c        |  3 ++-
>  tools/perf/util/evsel.c         | 20 +++++++++++++-------
>  tools/perf/util/evsel.h         |  4 ++--
>  tools/perf/util/metricgroup.c   |  3 ++-
>  tools/perf/util/parse-events.c  | 38 +++++++++++++++++++++++---------------
>  tools/perf/util/parse-events.h  |  9 ++++++---
>  tools/perf/util/parse-events.l  |  4 ++--
>  tools/perf/util/parse-events.y  |  2 +-
>  10 files changed, 63 insertions(+), 35 deletions(-)
> ---
> base-commit: 187c219b57eaf3e1b7a3cab2c6a8b7909bdbf4a9
> change-id: 20240407-perf_digit-72445b5edb62
> 
> Best regards,
> -- 
> Dominique Martinet | Asmadeus