Re: [PATCH 1/3] dt-bindings: iio: dac: add ad35xxr single output variants

From: David Lechner
Date: Fri May 10 2024 - 11:39:57 EST


On Fri, May 10, 2024 at 9:19 AM Angelo Dureghello
<adureghello@xxxxxxxxxxxx> wrote:
>
> From: Angelo Dureghello <adureghello@xxxxxxxxxxxx>
>
> Add support for ad3541r and ad3551r single output variants.
>
> Signed-off-by: Angelo Dureghello <adureghello@xxxxxxxxxxxx>
> ---
> .../devicetree/bindings/iio/dac/adi,ad3552r.yaml | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> index 8265d709094d..17442cdfbe27 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml

It would be nice to also add the datasheet links in the description.

> @@ -19,7 +19,9 @@ description: |
> properties:
> compatible:
> enum:
> + - adi,ad3541r
> - adi,ad3542r
> + - adi,ad3551r
> - adi,ad3552r
>
> reg:
> @@ -128,7 +130,9 @@ allOf:
> properties:
> compatible:
> contains:
> - const: adi,ad3542r
> + enum:
> + - adi,ad3541r
> + - adi,ad3542r
> then:
> patternProperties:
> "^channel@([0-1])$":
> @@ -158,7 +162,9 @@ allOf:
> properties:
> compatible:
> contains:
> - const: adi,ad3552r
> + enum:
> + - adi,ad3551r
> + - adi,ad3552r
> then:
> patternProperties:
> "^channel@([0-1])$":
> --
> 2.45.0.rc1
>
>

Since these are single channel, it would not hurt to restrict the
`reg` property of of the `channel@` nodes to 1.