Re: [PATCH v1 1/1] gpiolib: Return label, if set, for IRQ only line
From: Andy Shevchenko
Date: Fri May 10 2024 - 12:06:24 EST
On Fri, May 10, 2024 at 06:48:52PM +0300, Andy Shevchenko wrote:
> On Fri, May 10, 2024 at 06:42:28PM +0300, Andy Shevchenko wrote:
> > On Thu, May 09, 2024 at 04:23:07PM +0200, Bartosz Golaszewski wrote:
> > > On Thu, May 9, 2024 at 3:58 PM Andy Shevchenko
> > > <andy.shevchenko@xxxxxxxxx> wrote:
..
> > > Fair enough but I would like to know what your bigger plan is before
> > > picking this up.
> >
> > I stand corrected, this patch has an immediate effect on the generic
> > gpiolib_dbg_show() which does *not* use the above mentioned call..
>
> Ah, but it doesn't use gpiod_get_label() in the else branch either...
>
> I want to amend the else branch there to print similar or reuse the main one.
> For the latter I have locally a patch to modify gpiolib_dbg_show() to show
> the interrupt lines as well even if they are not requested.
I just shared that patch, if you are okay with both, it would be nice
to have them applied.
--
With Best Regards,
Andy Shevchenko