Re: [PATCH v2 4/4] arm64: dts: broadcom: Add support for BCM2712

From: Marc Zyngier
Date: Fri May 10 2024 - 12:13:24 EST


On 2024-05-10 15:35, Andrea della Porta wrote:
The BCM2712 SoC family can be found on Raspberry Pi 5.
Add minimal SoC and board (Rpi5 specific) dts file to be able to
boot from SD card and use console on debug UART.

Signed-off-by: Andrea della Porta <andrea.porta@xxxxxxxx>
---
arch/arm64/boot/dts/broadcom/Makefile | 1 +
.../boot/dts/broadcom/bcm2712-rpi-5-b.dts | 62 ++++
arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 302 ++++++++++++++++++
3 files changed, 365 insertions(+)
create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712.dtsi


[...]

+ psci {
+ method = "smc";
+ compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
+ cpu_on = <0xc4000003>;
+ cpu_suspend = <0xc4000001>;
+ cpu_off = <0x84000002>;

Please drop the PSCI function numbers. From PSCI-0.2, these are standard,
and what is implemented is discoverable.

+ };
+

[...]

+ timer {
+ compatible = "arm,armv8-timer";
+ interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) |
+ IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) |
+ IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) |
+ IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) |
+ IRQ_TYPE_LEVEL_LOW)>;

This is missing the EL2 virtual timer interrupt, as this is a VHE-capable
system.


+ /* This only applies to the ARMv7 stub */
+ arm,cpu-registers-not-fw-configured;

Please drop this. It makes no sense on a modern platform.

+ };
+};

Thanks,

M.
--
Jazz is not dead. It just smells funny...