Re: [PATCH] time: add MODULE_DESCRIPTION() to time test modules
From: Paul E. McKenney
Date: Sat May 11 2024 - 00:32:11 EST
On Fri, May 10, 2024 at 05:24:25PM -0700, Jeff Johnson wrote:
> Fix the make W=1 warnings:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/clocksource-wdtest.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/test_udelay.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/time_test.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
>From a clocksource-watchdog-test perspective:
Acked-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
> ---
> kernel/time/clocksource-wdtest.c | 1 +
> kernel/time/test_udelay.c | 1 +
> kernel/time/time_test.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/kernel/time/clocksource-wdtest.c b/kernel/time/clocksource-wdtest.c
> index d06185e054ea..62e73444ffe4 100644
> --- a/kernel/time/clocksource-wdtest.c
> +++ b/kernel/time/clocksource-wdtest.c
> @@ -22,6 +22,7 @@
> #include "tick-internal.h"
>
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Clocksource watchdog unit test");
> MODULE_AUTHOR("Paul E. McKenney <paulmck@xxxxxxxxxx>");
>
> static int holdoff = IS_BUILTIN(CONFIG_TEST_CLOCKSOURCE_WATCHDOG) ? 10 : 0;
> diff --git a/kernel/time/test_udelay.c b/kernel/time/test_udelay.c
> index 20d5df631570..783f2297111b 100644
> --- a/kernel/time/test_udelay.c
> +++ b/kernel/time/test_udelay.c
> @@ -155,5 +155,6 @@ static void __exit udelay_test_exit(void)
>
> module_exit(udelay_test_exit);
>
> +MODULE_DESCRIPTION("udelay test module");
> MODULE_AUTHOR("David Riley <davidriley@xxxxxxxxxxxx>");
> MODULE_LICENSE("GPL");
> diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c
> index 3e5d422dd15c..2889763165e5 100644
> --- a/kernel/time/time_test.c
> +++ b/kernel/time/time_test.c
> @@ -96,4 +96,5 @@ static struct kunit_suite time_test_suite = {
> };
>
> kunit_test_suite(time_test_suite);
> +MODULE_DESCRIPTION("time unit test suite");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: dd5a440a31fae6e459c0d6271dddd62825505361
> change-id: 20240510-time-md-0f1514019230
>