Re: [PATCH v1] perf stat: Don't display metric header for non-leader uncore events

From: Arnaldo Carvalho de Melo
Date: Sat May 11 2024 - 11:49:15 EST


On Thu, May 09, 2024 at 10:13:09PM -0700, Ian Rogers wrote:
> Achieve this by skipping events that aren't metric leaders when
> printing column headers and aggregation isn't disabled.
>
> The bug is long standing, the fixes tag is set to a refactor as that
> is as far back as is reasonable to backport.

Thanks, applied to perf-tools-next,

- Arnaldo

> Fixes: 088519f318be ("perf stat: Move the display functions to stat-display.c")
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
> tools/perf/util/stat-display.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index ea11e3437444..bb6bbb821b5a 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -1251,6 +1251,9 @@ static void print_metric_headers(struct perf_stat_config *config,
>
> /* Print metrics headers only */
> evlist__for_each_entry(evlist, counter) {
> + if (config->aggr_mode != AGGR_NONE && counter->metric_leader != counter)
> + continue;
> +
> os.evsel = counter;
>
> perf_stat__print_shadow_stats(config, counter, 0,
> --
> 2.45.0.118.g7fe29c98d7-goog