Re:  [PATCH linux-next] mm/huge_memory: remove redundant locking when parsing THP sysfs input

From: Matthew Wilcox
Date: Sat May 11 2024 - 12:05:26 EST


On Sat, May 11, 2024 at 02:40:48PM +0800, xu.xin16@xxxxxxxxxx wrote:
> From: Ran Xiaokai <ran.xiaokai@xxxxxxxxxx>
>
> Since sysfs_streq() only performs a simple memory comparison operation
> and will not introduce any sleepable operation, So there is no
> need to drop the lock when parsing input. Remove redundant lock
> and unlock operations to make code cleaner.

i disagree that it makes the code cleaner.