Re: [PATCH 0/3] sh: Fix missing prototypes (part three)

From: John Paul Adrian Glaubitz
Date: Mon May 13 2024 - 09:30:35 EST


Hi Geert,

On Mon, 2024-05-13 at 15:20 +0200, Geert Uytterhoeven wrote:
> Hi all,
>
> This patch series fixes more "no previous prototype for <foo>" warnings
> when building a kernel for SuperH, namely when building j2_defconfig.
>
> Thanks for your comments!
>
> Geert Uytterhoeven (3):
> sh: of-generic: Add missing #include <asm/clock.h>
> sh: smp: Protect setup_profiling_timer() by CONFIG_PROFILING
> sh: setup: Add missing forward declaration for sh_fdt_init()
>
> arch/sh/boards/of-generic.c | 2 ++
> arch/sh/include/asm/setup.h | 1 +
> arch/sh/kernel/smp.c | 2 ++
> 3 files changed, 5 insertions(+)

Thanks a lot for fixing these. I have run into these as well and except
for patch #2 where you found the proper fix, my proposed fixes looked
exactly the same.

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913