Re: [PATCH] ASoC: intel: Constify struct snd_soc_ops

From: Pierre-Louis Bossart
Date: Mon May 13 2024 - 09:46:39 EST




On 5/11/24 13:42, Christophe JAILLET wrote:
> Constifying "struct snd_soc_ops" moves some data to a read-only section, so
> increase overall security.
>
> This structure is also part of scripts/const_structs.checkpatch.
>
> As an example, on a x86_64, with allmodconfig:
> Before:
> text data bss dec hex filename
> 6315 3696 0 10011 271b sound/soc/intel/boards/ehl_rt5660.o
>
> After:
> text data bss dec hex filename
> 6379 3648 0 10027 272b sound/soc/intel/boards/ehl_rt5660.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> Compile tested only.
>
> I hope that it can be applied with this single patch because all files are
> in sound/soc/intel/boards/

Doesn't apply for me, can you rebase and resend?

CONFLICT (content): Merge conflict in
sound/soc/intel/boards/sof_maxim_common.h
Auto-merging sound/soc/intel/boards/sof_maxim_common.c
CONFLICT (content): Merge conflict in
sound/soc/intel/boards/sof_maxim_common.c
error: Failed to merge in the changes.

Probably a result of all the changes in this directory...
Thanks!