Re: [PATCH v2 02/11] dt-bindings: net: add phy-supply property for stm32

[Christophe ROULLIER]

Hi

On 4/26/24 17:30, Rob Herring wrote:
> On Fri, Apr 26, 2024 at 02:56:58PM +0200, Christophe Roullier wrote:
> > Phandle to a regulator that provides power to the PHY. This
> > regulator will be managed during the PHY power on/off sequence.
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Signed-off-by: Christophe Roullier <christophe.roullier@xxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
> > index b901a432dfa9..7c3aa181abcb 100644
> > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
> > @@ -84,6 +84,9 @@ properties:
> >             - description: offset of the control register
> >             - description: field to set mask in register
> >   
> > +  phy-supply:
> > +    description: PHY regulator
> This is for which PHY? The serdes phy or ethernet phy? This only makes
> sense here if the phy is part of the MAC. Otherwise, it belongs in the
> phy node.
>
> Rob

You are right, normally it should be managed in Ethernet PHY (Realtek, 
Microchip etc...)

Lots of glue manage this like this. Does it forbidden now ? if yes need 
to update PHY driver to manage this property.