Re: [PATCH net-next v3] net: dsa: mv88e6xxx: control mdio bus-id truncation for long paths

From: Jakub Kicinski
Date: Mon May 13 2024 - 11:34:28 EST


On Tue, 7 May 2024 12:03:31 +0000 Josua Mayer wrote:
> > The idea and implementation is reasonable but this could affect other drivers than mv88e6xxx, why not move that logic to mdiobus_register() and tracking the truncation index globally within the MDIO bus layer?
> Conceptually I agree, it would be nice to have a centralized
> solution to this problem, it probably can occur in multiple places.
>
> My reasoning is that solving the problem within a single driver
> is a much smaller task, especially for sporadic contributors
> who lack a deep understanding for how all layers interact.
>
> Perhaps agreeing on a good solution within this driver
> can inform a more general solution to be added later.

I agree with Florian, FWIW. The choice of how to truncate is a bit
arbitrary, if core does it at least it will be consistent.