Re: [PATCH] sched/deadline: Fix grammar and typos in comments
From: Phil Auld
Date: Mon May 13 2024 - 12:30:39 EST
On Mon, May 13, 2024 at 04:19:10PM +0100 Paul Sherwood wrote:
> On 2024-05-13 14:58, Phil Auld wrote:
> > On Sat, May 11, 2024 at 09:26:44AM +0100 Paul Sherwood wrote:
> > > - conjugate verb to match subject of sentence
> > > - s/a entity/an entity/g
> > > - s/this misbehave/this misbehaviour/
> > > - a few typos
> > >
> > - not starting all the lines of a commit message with "-", priceless.
> >
> > Plus, you're just repeating what's in the actual patch.
> >
> > Otherwise, these changes themselves look good to me.
>
> Thanks for the feedback - would you like me to re-submit without the
> bullet-points, or without the text entirely?
>
Personally I'd rather a sentence or two saying something like
"Fix some types and grammar issues in sched deadline comments."
Or something. I know that's basically same as the title, but
that gets lost in the subject line, so maybe worded a little
differently? For this it probably doesn't need much but does
need something.
I'm not the one to merge it though so I don't know if the
maintainer wanted to just fix it up at the time. Just my
opinion...
For the changes themselves, fwiw,
Reviewed-by: Phil Auld <pauld@xxxxxxxxxx>
Cheers,
Phil
> br
> Paul
>
--