[PATCH] iio: temperature: mlx90635: Fix ERR_PTR dereference in mlx90635_probe()
From: Harshit Mogalapalli
Date: Mon May 13 2024 - 14:47:39 EST
When devm_regmap_init_i2c() fails, ragmap_ee could be error pointer,
instead of checking for IS_ERR(ragmap_ee), regmap is checked which looks
like a copy paste error.
Fixes: a1d1ba5e1c28 ("iio: temperature: mlx90635 MLX90635 IR Temperature sensor")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
---
This is found using smatch, only compile tested.
---
drivers/iio/temperature/mlx90635.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/temperature/mlx90635.c b/drivers/iio/temperature/mlx90635.c
index 1f5c962c1818..2b61489d5ee0 100644
--- a/drivers/iio/temperature/mlx90635.c
+++ b/drivers/iio/temperature/mlx90635.c
@@ -947,8 +947,8 @@ static int mlx90635_probe(struct i2c_client *client)
"failed to allocate regmap\n");
regmap_ee = devm_regmap_init_i2c(client, &mlx90635_regmap_ee);
- if (IS_ERR(regmap))
- return dev_err_probe(&client->dev, PTR_ERR(regmap),
+ if (IS_ERR(regmap_ee))
+ return dev_err_probe(&client->dev, PTR_ERR(regmap_ee),
"failed to allocate regmap\n");
mlx90635 = iio_priv(indio_dev);
--
2.39.3