Re: [PATCH] gpiolib: cdev: fix uninitialised kfifo

From: Kent Gibson
Date: Mon May 13 2024 - 23:37:12 EST


On Fri, May 10, 2024 at 04:06:16PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
>
> On Fri, 10 May 2024 14:53:42 +0800, Kent Gibson wrote:
> > If a line is requested with debounce, and that results in debouncing
> > in software, and the line is subsequently reconfigured to enable edge
> > detection then the allocation of the kfifo to contain edge events is
> > overlooked. This results in events being written to and read from an
> > unitialised kfifo. Read events are returned to userspace.
> >
> > Initialise the kfifo in the case where the software debounce is
> > already active.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] gpiolib: cdev: fix uninitialised kfifo
> commit: 3c1625fe5a2e0d68cd7b68156f02c1b5de09a161
>

I've got a patch series to tidy this up and catch any similar errors
earlier going forward.
It is of course based on this patch, but that isn't in gpio/for-next yet.
How should I proceed?

Cheers,
Kent.