Re: [PATCH V5 3/6] dt-bindings: PCI: qcom: Document the IPQ9574 PCIe controller.

From: Manivannan Sadhasivam
Date: Tue May 14 2024 - 03:28:15 EST


On Mon, May 13, 2024 at 08:48:19AM +0200, Krzysztof Kozlowski wrote:
> On 12/05/2024 10:28, devi priya wrote:
>
> >
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - qcom,pcie-ipq9574
> > + then:
> > + properties:
> > + clocks:
> > + minItems: 6
> > + maxItems: 6
> > + clock-names:
> > + items:
> > + - const: ahb # AHB clock
> > + - const: aux # Auxiliary clock
> > + - const: axi_m # AXI Master clock
> > + - const: axi_s # AXI Slave clock
> > + - const: axi_bridge # AXI bridge clock
> > + - const: rchng
>
> That's introducing one more order of clocks... Please keep it
> consistent. The only existing case with ahb has it at after axi_m and
> others. Why making things everytime differently?
>
> I also to propose to finally drop the obvious comments, like "AHB
> clock". It cannot be anything else. AXI Master / slave are descriptive,
> so should stay.
>

+1 to drop the names.

- Mani

--
மணிவண்ணன் சதாசிவம்