Re: [PATCH v3] scsi: ufs: Allow RTT negotiation
From: Bart Van Assche
Date: Tue May 14 2024 - 08:56:26 EST
On 5/13/24 23:08, Avri Altman wrote:
+/* bMaxNumOfRTT is equal to two after device manufacturing */
+#define DEFAULT_MAX_NUM_RTT 2
[ ... ]
+ /* do not override if it was already written */
+ if (dev_rtt != DEFAULT_MAX_NUM_RTT)
+ return;
I haven't found any text in the UFSHCI 4.0 specification that says
that the default value for the number of outstanding RTT requests
should be 2. Did I perhaps overlook something? If I didn't overlook
anything, the driver should not try to check whether dev_rtt is at its
default value.
Thanks,
Bart.