Re: [PATCH] arm64: dts: qcom: qdu/qru1000-idp: Fix the voltage setting

From: Krzysztof Kozlowski
Date: Tue May 14 2024 - 09:31:52 EST


On 14/05/2024 15:10, Komal Bajaj wrote:
> Fixing the regulator voltages for qdu/qru1000 idp boards.
> In particular -
> - smps4 is 1.574V min and 2.04V max
> - smps5 is 1.2V min and 1.4V max
> - smps6 is 0.382V min and 1.12V max

Wait, why? This looks, at least partially, you are changing from fixed
voltage choice to full range, without clear explanation.

> - smps8 is fixed at 0.752V


>
> Fixes: d1f2cfe2f669 ("arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs")
> Signed-off-by: Komal Bajaj <quic_kbajaj@xxxxxxxxxxx>

Best regards,
Krzysztof