Re: [PATCH wireless-next] ath11k: Fix error path in ath11k_pcic_ext_irq_config

From: Jakub Kicinski
Date: Tue May 14 2024 - 09:52:14 EST


On Tue, 14 May 2024 13:24:28 +0000 (UTC) Kalle Valo wrote:
> > If one of the dummy allocation fails in ath11k_pcic_ext_irq_config(),
> > the previous allocated devices might leak due to returning without
> > deallocating the devices.
> >
> > Instead of returning on the error path, deallocate all the previously
> > allocated net_devices and then return.
> >
> > Fixes: bca592ead825 ("wifi: ath11k: allocate dummy net_device dynamically")
> > Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
> > Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
>
> As commit bca592ead825 is in net-next I think this patch needs to go to v6.10, right?

There's no rush, FWIW, we can pick up the conversion after the merge
window.