RE: [PATCH bpf] bpf, docs: Fix the description of 'src' in ALU instructions
From: dthaler1968
Date: Tue May 14 2024 - 10:34:12 EST
Puranjay Mohan <puranjay@xxxxxxxxxx> wrote:
> An ALU instruction's source operand can be the value in the source
register or the
> 32-bit immediate value encoded in the instruction. This is controlled by
the 's' bit of
> the 'opcode'.
>
> The current description explicitly uses the phrase 'value of the source
register'
> when defining the meaning of 'src'.
>
> Change the description to use 'source operand' in place of 'value of the
source
> register'.
>
> Signed-off-by: Puranjay Mohan <puranjay@xxxxxxxxxx>
Acked-by: Dave Thaler <dthaler1968@xxxxxxxxx>
> ---
> Documentation/bpf/standardization/instruction-set.rst | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/bpf/standardization/instruction-set.rst
> b/Documentation/bpf/standardization/instruction-set.rst
> index a5ab00ac0b14..2e17b365388e 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -292,8 +292,9 @@ Arithmetic instructions ``ALU`` uses 32-bit wide
> operands while ``ALU64`` uses 64-bit wide operands for otherwise
identical
> operations. ``ALU64`` instructions belong to the
> base64 conformance group unless noted otherwise.
> -The 'code' field encodes the operation as below, where 'src' and 'dst'
refer -to the
> values of the source and destination registers, respectively.
> +The 'code' field encodes the operation as below, where 'src' refers to
> +the the source operand and 'dst' refers to the value of the destination
> +register.
>
> ===== ===== =======
> ==========================================================
> name code offset description
> --
> 2.40.1