Re: [PATCH] dmaengine: ioatdma: Fix missing kmem_cache_destroy()

From: Dave Jiang
Date: Tue May 14 2024 - 11:38:29 EST




On 5/14/24 3:52 AM, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <n.shubin@xxxxxxxxx>
>
> Fix missing kmem_cache_destroy() for ioat_sed_cache in
> ioat_exit_module().
>
> Noticed via:
>
> ```
> modprobe ioatdma
> rmmod ioatdma
> modprobe ioatdma
> debugfs: Directory 'ioat_sed_ent' with parent 'slab' already present!
> ```
>
> Fixes: c0f28ce66ecf ("dmaengine: ioatdma: move all the init routines")
> Signed-off-by: Nikita Shubin <n.shubin@xxxxxxxxx>

Thanks!

Acked-by: Dave Jiang <dave.jiang@xxxxxxxxx>

> ---
> drivers/dma/ioat/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> index 9c364e92cb82..61329c279040 100644
> --- a/drivers/dma/ioat/init.c
> +++ b/drivers/dma/ioat/init.c
> @@ -1445,6 +1445,7 @@ module_init(ioat_init_module);
> static void __exit ioat_exit_module(void)
> {
> pci_unregister_driver(&ioat_pci_driver);
> + kmem_cache_destroy(ioat_sed_cache);
> kmem_cache_destroy(ioat_cache);
> }
> module_exit(ioat_exit_module);
>
> ---
> base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
> change-id: 20240514-ioatdma_fixes-7460f4fd7d51
>
> Best regards,