Re: [PATCH v2 1/1] lib: add version into /proc/allocinfo output
From: Suren Baghdasaryan
Date: Tue May 14 2024 - 16:19:46 EST
On Tue, May 14, 2024 at 9:58 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> On Tue, May 14, 2024 at 09:31:28AM -0700, Suren Baghdasaryan wrote:
> > Add version string and a header at the beginning of /proc/allocinfo to
> > allow later format changes. Example output:
> >
> > > head /proc/allocinfo
> > allocinfo - version: 1.0
> > # <size> <calls> <tag info>
> > 0 0 init/main.c:1314 func:do_initcalls
> > 0 0 init/do_mounts.c:353 func:mount_nodev_root
> > 0 0 init/do_mounts.c:187 func:mount_root_generic
> > 0 0 init/do_mounts.c:158 func:do_mount_root
> > 0 0 init/initramfs.c:493 func:unpack_to_rootfs
> > 0 0 init/initramfs.c:492 func:unpack_to_rootfs
> > 0 0 init/initramfs.c:491 func:unpack_to_rootfs
> > 512 1 arch/x86/events/rapl.c:681 func:init_rapl_pmus
> > 128 1 arch/x86/events/rapl.c:571 func:rapl_cpu_online
> >
> > Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>
>
> Ah yeah, good idea. (Do we have versioning like this anywhere else in
> our /proc files? It seems a nice thing to add...)
Yes, /proc/slabinfo has a similar header that includes a version number.
>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
Thanks!
>
> --
> Kees Cook