Re: [PATCH RFC] ASoC: amlogic: do not use dpcm_playback/capture flags

From: Kuninori Morimoto
Date: Tue May 14 2024 - 19:11:17 EST



Hi

> > dpcm_playback/capture flags are being deprecated in ASoC.
> > Use playback/capture_only flags instead
> >
> > Suggested-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> > Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> > ---
> >
> > Following Kuninori's series, dpcm_playback/capture will be ignored.
> > However, properly disabling stream direction is important for Amlogic
> > audio drivers.
> >
> > I'm not too sure how this should be applied to avoid breaking bisect,
> > before or after Kuninori's series. Maybe it should be merged into it ?
>
> Probably better to integrate it I think?

ASoC needs dpcm_xxx flag *before* my patch.
Your patch is replacing it to xxx_only flag, so it should be applied
*after* my patch. So integrate/merge is good idea, I think.

Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto