Re: [PATCH] net: hsr: Setup and delete proxy prune timer only when RedBox is enabled
From: Sebastian Andrzej Siewior
Date: Wed May 15 2024 - 02:41:56 EST
On 2024-05-14 11:13:06 [+0200], Lukasz Majewski wrote:
> The timer for removing entries in the ProxyNodeTable shall be only active
> when the HSR driver works as RedBox (HSR-SAN).
>
> Moreover, the obsolete del_timer_sync() is replaced with
> timer_delete_sync().
>
> This patch improves fix from commit 3c668cef61ad
> ("net: hsr: init prune_proxy_timer sooner") as the prune node
> timer shall be setup only when HSR RedBox is supported in the node.
Is it problematic to init/ delete the timer in non-redbox mode? It looks
easier and it is not a hotpath.
> Signed-off-by: Lukasz Majewski <lukma@xxxxxxx>
Sebastian