Re: [PATCH v3] ext4: Don't reduce symlink i_mode by umask if no ACL support
From: Christian Brauner
Date: Wed May 15 2024 - 12:50:07 EST
On Fri, May 10, 2024 at 12:47:21PM +0100, David Howells wrote:
>
> If CONFIG_EXT4_FS_POSIX_ACL=n then the fallback version of ext4_init_acl()
> will mask off the umask bits from the new inode's i_mode. This should not
> be done if the inode is a symlink. If CONFIG_EXT4_FS_POSIX_ACL=y, then we
> go through posix_acl_create() instead which does the right thing with
> symlinks.
>
> However, this is actually unnecessary now as vfs_prepare_mode() has already
> done this where appropriate, so fix this by making the fallback version of
> ext4_init_acl() do nothing.
>
> Fixes: 484fd6c1de13 ("ext4: apply umask if ACL support is disabled")
> Suggested-by: Miklos Szeredi <miklos@xxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> cc: Max Kellermann <max.kellermann@xxxxxxxxx>
> cc: Jan Kara <jack@xxxxxxxx>
> cc: Christian Brauner <brauner@xxxxxxxxxx>
> cc: linux-ext4@xxxxxxxxxxxxxxx
> cc: linux-fsdevel@xxxxxxxxxxxxxxx
> ---
Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>