RE: [v3] cpufreq: amd-pstate: fix the memory to free after epp exist

From: Yuan, Perry
Date: Wed May 15 2024 - 22:49:05 EST


[AMD Official Use Only - AMD Internal Distribution Only]

Hi Peng,

> -----Original Message-----
> From: zhida312@xxxxxxxxxxx <zhida312@xxxxxxxxxxx>
> Sent: Wednesday, May 15, 2024 10:54 AM
> To: rafael@xxxxxxxxxx; viresh.kumar@xxxxxxxxxx
> Cc: Peng Ma <andypma@xxxxxxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx>;
> Shenoy, Gautham Ranjal <gautham.shenoy@xxxxxxx>; Limonciello, Mario
> <Mario.Limonciello@xxxxxxx>; Yuan, Perry <Perry.Yuan@xxxxxxx>; linux-
> pm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [v3] cpufreq: amd-pstate: fix the memory to free after epp exist

The subject need to be update as below. " git format-patch -1 -v 3"

[PATCH v3] cpufreq: amd-pstate: fix the memory to free after epp exist


>
> From: andypma <andypma.tencent.com>
>
> the cpudata memory from kzmalloc in epp init function is not free after epp exist,
> so we should free it.
>
> Signed-off-by: Peng Ma <andypma@xxxxxxxxxxx>
>
> Changes since v2:
> update Signed-off-by to Peng Ma <andypma@xxxxxxxxxxx>.
> set a space between if and "(".
>
> Changes since v1:
> check whether it is empty before releasing.
> set driver_data is NULL after free.
> ---
> drivers/cpufreq/amd-pstate.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index
> 6a342b0c0140..1b7e82a0ad2e 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1441,6 +1441,13 @@ static int amd_pstate_epp_cpu_init(struct
> cpufreq_policy *policy)
>
> static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) {
> + struct amd_cpudata *cpudata = policy->driver_data;
> +
> + if (cpudata) {
> + kfree(cpudata);
> + policy->driver_data = NULL;
> + }
> +
> pr_debug("CPU %d exiting\n", policy->cpu);
> return 0;
> }
> --
> 2.41.0