Re: [PATCH 1/3] crypto: X25519 low-level primitives for ppc64le.

From: Andy Polyakov
Date: Thu May 16 2024 - 04:38:55 EST


Hi,

+.abiversion 2

I'd prefer that was left to the compiler flags.

Problem is that it's the compiler that is responsible for providing this directive in the intermediate .s prior invoking the assembler. And there is no assembler flag to pass through -Wa. If concern is ABI neutrality, then solution would rather be #if (_CALL_ELF-0) == 2/#endif. One can also make a case for

#ifdef _CALL_ELF
abiversion _CALL_ELF
#endif

Cheers.