Re: [PATCH v2] locking/atomic: scripts: fix ${atomic}_sub_and_test() kerneldoc

From: Peter Zijlstra
Date: Thu May 16 2024 - 04:53:27 EST


On Thu, May 16, 2024 at 10:45:58AM +0200, Mark Rutland wrote:
> On Wed, May 15, 2024 at 01:37:10PM +0000, Carlos Llamas wrote:
> > For ${atomic}_sub_and_test() the @i parameter is the value to subtract,
> > not add. Fix the typo in the kerneldoc template and generate the headers
> > with this update.
> >
> > Fixes: ad8110706f38 ("locking/atomic: scripts: generate kerneldoc comments")
> > Cc: Mark Rutland <mark.rutland@xxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > Suggested-by: Mark Rutland <mark.rutland@xxxxxxx>
> > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > Signed-off-by: Carlos Llamas <cmllamas@xxxxxxxxxx>
> > ---
> >
> > Notes:
> > v2: fix kerneldoc template instead, as pointed out by Mark
>
> Thanks for this!
>
> Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
>
> Peter, Ingo, are you happy to queue this up in the tip tree?

Yep can do. I'll sit on it until after the merge window though.